Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild for gfortran 7 for OSX (fixed) #48

Merged
merged 19 commits into from
Aug 31, 2019
Merged

Rebuild for gfortran 7 for OSX (fixed) #48

merged 19 commits into from
Aug 31, 2019

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Aug 26, 2019 •
edited
Loading

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #47
Closes #49

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • license_file entry is missing, but is expected.

@beckermr beckermr changed the title Rebuild for gfortran 7 for OSX (fixed_ Rebuild for gfortran 7 for OSX (fixed) Aug 26, 2019
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

1 similar comment
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@beckermr beckermr mentioned this pull request Aug 26, 2019
Closed
@beckermr
Copy link
Member Author

@conda-forge-admin, please rerender

kmuehlbauer
kmuehlbauer reviewed Aug 27, 2019
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@beckermr
Copy link
Member Author

And as I thought this will take work:

gcc -pthread -B $PREFIX/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I$PREFIX/include/python3.7m -c gribapi/_bindings.c -o ./gribapi/_bindings.o
unable to execute 'gcc': No such file or directory
ERROR:root:can't compile ecCodes bindings
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/unixccompiler.py", line 118, in _compile
    extra_postargs)
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/ccompiler.py", line 909, in spawn
    spawn(cmd, dry_run=self.dry_run)
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/spawn.py", line 36, in spawn
    _spawn_posix(cmd, search_path, dry_run=dry_run)
  File "/home/conda/feedstock_root/build_artifacts/python-eccodes_1566907882659/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.7/distutils/spawn.py", line 159, in _spawn_posix
    % (cmd, exit_status))
distutils.errors.DistutilsExecError: command 'gcc' failed with exit status 1

@beckermr
Copy link
Member Author

I need to add the c compilers too.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr
Copy link
Member Author

@conda-forge-admin, please rerender

@beckermr
Copy link
Member Author

OK @conda-forge/python-eccodes @kmuehlbauer This PR is ready to go. It now builds the python 3 version only and compiles the fast bindings as well!

kmuehlbauer
kmuehlbauer approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @beckermr! I'm all for merging this. @ocefpaf might have one last look, if we did not miss anything.

@beckermr
Copy link
Member Author

Bump here. We should go ahead and merge.

@kmuehlbauer kmuehlbauer merged commit 479f927 into conda-forge:master Aug 31, 2019
@kmuehlbauer kmuehlbauer mentioned this pull request Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmuehlbauer kmuehlbauer kmuehlbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version madness
4 participants
@beckermr @conda-forge-linter @kmuehlbauer @conda-forge-admin